Edgewall Software

Ticket #800 (closed defect: fixed)

Opened 4 years ago

Last modified 2 years ago

'Add New Milestone' not working

Reported by: Brad Anderson <brad@…> Owned by: cmlenz
Priority: high Milestone: 0.8
Component: roadmap Version: devel
Severity: critical Keywords:
Cc: brad@…

Description

I pulled Revision 940 to my local and was unable to create a new milestone. The problem was that the 'id' variable in Milestone.py was not being set to a default of -1 by the dictionary's get() method.

I'm a total Python newbie, so someone needs to check if the patch is a) in the right place, and b) the proper Python way. I don't think removing the hidden field name="id" on the html form is the way, because at times, it's filled with the milestone name for other modes.

Attachments

add_milestone.diff (0.5 KB) - added by brad@… 4 years ago.
patch file
add_milestone.2.diff (0.5 KB) - added by brad@… 4 years ago.
patch file (Try #2)

Change History

Changed 4 years ago by brad@…

patch file

Changed 4 years ago by Brad Anderson <brad@…>

Oops, forgot some particulars:

Gentoo Linux (2.6.6 kernel) Python 2.3.3 mod_python

anything else?

Changed 4 years ago by cmlenz

  • priority changed from normal to high
  • status changed from new to assigned
  • severity changed from normal to critical
  • milestone set to 0.8

Changed 4 years ago by Brad Anderson <brad@…>

I was getting an error with the patch, something like

TypeError: len() of unsized object

So I changed the check to:

if id == "":
   id = -1;

Changed 4 years ago by brad@…

patch file (Try #2)

Changed 4 years ago by jonas

test

Changed 4 years ago by jonas

test2

Changed 4 years ago by cmlenz

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in [941].

Add/Change #800 ('Add New Milestone' not working)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cmlenz. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.