Edgewall Software

Ticket #7643 (closed defect: fixed)

Opened 4 months ago

Last modified 6 weeks ago

Trac RSS feed invalid when svn log message has control characters

Reported by: foom@… Owned by: rblank
Priority: normal Milestone: 0.11.3
Component: general Version: 0.11-stable
Severity: normal Keywords:
Cc:

Description

Somebody accidently committed a revision to my svn repository with an ESC control character (0x1b) in the log message. This ends up being echoed raw into the RSS XML feed, which causes an XML parser error in xml parsers trying to read it.

SVN itself has no issue with this char in the log message: svn protocol returns it as is, and in the HTTP protocol which uses XML it returns "?\027" (literally questionmark backslash 0 2 7).

It seems like trac should similarly escape the log message text in its output as well, to keep it well-formed.

I'm using version 0.11dev-r6396 which I realize is somewhat out-of-date, but I did try to look through the commits and bug reports to see if it had been fixed.

Attachments

Change History

Changed 2 months ago by rblank

  • owner set to rblank
  • milestone set to 0.11.3

I'll put this on my to-do list. I wonder if this can happen elsewhere (wiki pages, attachments, file content, ...).

Changed 2 months ago by rblank

  • version set to 0.11-stable

#7637 was closed as a duplicate.

Changed 6 weeks ago by rblank

  • status changed from new to closed
  • resolution set to fixed

Fixed in [7718] by removing all control characters not allowed in XML 1.0, that is, every character between 0x00 and 0x1f except 0x09, 0x0a and 0x0d, after rendering a template.

Add/Change #7643 (Trac RSS feed invalid when svn log message has control characters)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from rblank. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.