Ticket #7643 (closed defect: fixed)
Trac RSS feed invalid when svn log message has control characters
| Reported by: | foom@… | Owned by: | rblank |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.3 |
| Component: | general | Version: | 0.11-stable |
| Severity: | normal | Keywords: | |
| Cc: |
Description
Somebody accidently committed a revision to my svn repository with an ESC control character (0x1b) in the log message. This ends up being echoed raw into the RSS XML feed, which causes an XML parser error in xml parsers trying to read it.
SVN itself has no issue with this char in the log message: svn protocol returns it as is, and in the HTTP protocol which uses XML it returns "?\027" (literally questionmark backslash 0 2 7).
It seems like trac should similarly escape the log message text in its output as well, to keep it well-formed.
I'm using version 0.11dev-r6396 which I realize is somewhat out-of-date, but I did try to look through the commits and bug reports to see if it had been fixed.


