Cleanup Trac Imports

[cg@…]

Since I'm using Trac very much I have a big problem with it. It just leaks memory, a gc.collect() collects more than 10.000 objects after some requests.

I have just created a patch file that cleans up unused imports, star-imports are also deleted ('cause they clutter the namespace). Maybe that's a startingpoint to cleanup some things and let it leak less memory.

[cg@…]

The patch file that fixes some import-errors

[Christopher Grebs <cg@…>]

Oh, by the way. The patch was created with the latest changeset included ([7455])

I'm still not sure if it really helps to minimize memleak but it cleans it up anyway :D

[Christopher Grebs <cg@…>]

Replying to Christopher Grebs <cg@…>:

Oh, by the way. The patch was created with the latest changeset included ([7455]) I'm still not sure if it really helps to minimize memleak but it cleans it up anyway :D

argh, wrong link. Anyway the latest trunk (not 0.11 stable branch) is the base.

[mgood]

Thanks for looking at the unused imports. Getting rid of some of those helps keep the code clean, but is not going to have a significant impact on memory usage. Imported modules are always referred to by sys.modules, so they will never get garbage collected (this is intentional to make sure modules are only executed the first time you import them).

However, I think most of the "import *"s are intentional. Trac uses __all__ extensively to ensure that "import *" only imports names intentionally exposed by that module and does not pollute the namespace. This is also convenient for commonly used modules like "trac.core" so that you don't have to remember to add each of these as you start to use them.

Can you re-submit a patch that does not include the "import *" expansions?

[Christopher Grebs <cg@…>]

New patch (without * imports replaced)

[Christopher Grebs <cg@…>]

I just added the new patch – this should work... thank's for answer my ticket. Regarding memory-leaking: I learned that python2.4 can't free reserved memory and I think that's the most depressing thingy...

[rblank]

Some cleanup would indeed be needed.