Edgewall Software

Ticket #7469 (closed defect: fixed)

Opened 5 months ago

Last modified 7 weeks ago

Refactoring gone bad, patch to correct

Reported by: palgarvio Owned by: jruigrok
Priority: highest Milestone: 0.12
Component: general Version: 0.12dev
Severity: blocker Keywords:
Cc:

Description

The correct refactoring would have been:

  • trac/web/main.py

     
    276276                translation.get_available_locales()] 
    277277 
    278278            preferred = req.session.get('language', req.languages) 
    279             if isinstance(preferred, list): 
     279            if not isinstance(preferred, list): 
    280280                preferred = [preferred] 
    281281            return Locale.negotiate(preferred, available, sep='-') 

Attachments

Change History

Changed 5 months ago by palgarvio

  • owner set to jruigrok

Changed 5 months ago by jruigrok

  • status changed from new to closed
  • resolution set to fixed

Fixed in r7412. Thanks.

Changed 7 weeks ago by anonymous

  • status changed from closed to reopened
  • resolution fixed deleted

Changed 7 weeks ago by anonymous

  • status changed from reopened to closed
  • resolution set to fixed

Add/Change #7469 (Refactoring gone bad, patch to correct)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from jruigrok. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.