[patch] The md5 module is deprecated in python, use hashlib instead

[mad]

Hello,

the md5 module is deprecated, hashlib should be used instead. here is a simple patch against 0.11 to kill the warnings.

[mad]

patch to replace the usage of the depecated md5 module with hashlib

[nkantrowitz]

This is not possible without dropping support for Python 2.4. Not going to happen for a while.

[eblot]

It could be implemented with compatibility for previous release of Python:

try:
    import hashlib
    md = hashlib.md5()
except ImportError:
    # for Python << 2.5
    import md5
    md = md5.new()

[mad]

the patch was wrong in some way, with it applied the login href was missing. strange...

[Remy Blank <remy.blank@…>]

Yes, the search and replace was a bit too hasty. I would guess that the substitution at line 38 of trac/web/auth.py is wrong.

[mad]

Updated version with sha module replacement and fixed login href

[Remy Blank <remy.blank@…>]

Patch against 0.11-stable that implements the solution suggested by eblot

[Remy Blank <remy.blank@…>]

The patch above imports either hashlib.md5 or md5.md5 into trac.util, and all users of md5 import it from there.

The same import hack is applied separately to contrib/htdigest.py so that it doesn't have to depend on trac.util.

The patch proposed by mad also fixed trac/wiki/default-pages/TracStandalone, but I understand these pages are imported from the live Trac instance on t.e.o during the release process. So I'll patch TracStandalone with the same hack.

[cboos]

attachment:7458-hashlib-r7376.patch looks great, I'll apply it later today.

[cboos]

Applied with minor tweaking in (moved the hashlib import logic in trac.util.compat, where we usually place this sort of things). It's still importable directly from trac.util though.

Patch applied in r7384.