Edgewall Software

Ticket #7324 (closed defect: fixed)

Opened 7 months ago

Last modified 7 weeks ago

Firefox crashes when performing large quick search

Reported by: fermulator Owned by: rblank
Priority: normal Milestone: 0.11.3
Component: search system Version: 0.11b1
Severity: normal Keywords:
Cc: fermulator@…

Description

Steps to reproduce issue:

  1. Using Firefox...
  2. Open a trac website.
  3. Provided we have a ticket (semi-large) with several comments (20+).
  4. Copy into the clipboard a sentence (15+ words) from a comment in said ticket.
  5. In the quick search of trac, paste that large sentence and perform the search. ... the results will be displayed ... probably only the ONE result of that ticket since the sentence would probably be unique.
  6. Click on the link to the ticket.

...

trac will cause firefox to use A LOT of CPU, and the ticket could take upwards of 2+ minutes to load. Yikes!

Sometimes even firefox will crash entirely ...

We suspect this has to do with syntax highlighting javascript from trac itself.

Comparison:

  1. Do a quicksearch for the TICKET NUMBER (i.e. #999)
  2. trac will automatically load the ticket, and it will be fast!

In the comparison case the only difference I can see is that there wouldn't be syntax highlighting ... ?

Attachments

search-limit.diff (0.6 KB) - added by athomas 7 months ago.
Limit number of highlighted words on search

Change History

Changed 7 months ago by athomas

Limit number of highlighted words on search

Changed 7 months ago by athomas

Give this patch a try.

Changed 7 months ago by anonymous

What version of Firefox? I can't reproduce this in 2.0.0.14.

Changed 3 months ago by rblank

  • owner changed from cboos to rblank
  • milestone set to 0.11.3

I can reproduce this issue in Firefox 2.0.0.17, for example using #31 and following the procedure provided in the ticket description. The browser never crashes, but I get the message box about "a script taking too long" several times before the page displays.

Limiting the number of highlights sounds like a good idea.

Changed 7 weeks ago by rblank

  • status changed from new to closed
  • resolution set to fixed

Fixed in [7695] by limiting highlighting to 10 terms, but also requiring terms to be at least 3 characters.

Changed 7 weeks ago by anonymous

  • owner changed from rblank to anonymous

iiourzoirhyzeoh zeo

Changed 7 weeks ago by rblank

  • owner changed from anonymous to rblank

Add/Change #7324 (Firefox crashes when performing large quick search)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from rblank. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.