Edgewall Software

Ticket #7111 (new defect)

Opened 7 months ago

Last modified 5 months ago

'checkbox' filter options are created as radio buttons a vise-versa

Reported by: carnold@… Owned by: cboos
Priority: normal Milestone: 0.12
Component: web frontend Version: devel
Severity: minor Keywords: query jquery javascript
Cc:

Description (last modified by thatch) (diff)

I was robbing some code and I stumbled upon some brokenness:

source:/trunk/trac/htdocs/js/query.js#L196

property.type == "checkbox" should be property.type == "radio"

Attachments

Change History

  Changed 7 months ago by thatch

  • description modified (diff)
  • milestone changed from 0.11.1 to 0.11

Thanks for the catch. It looks like the create* calls in there are also somewhat reversed.

The template code to compare against is source:trunk/trac/ticket/templates/query.html#L80

  Changed 7 months ago by cboos

Well, the whole query.js is dating and should be rewritten using jQuery.

  Changed 7 months ago by jruigrok

But that's also something that can be done for 0.11.1, yes?

It's not like it's a blocker issue or a must-need for 0.11.0's release.

follow-up: ↓ 6   Changed 7 months ago by jruigrok

  • milestone changed from 0.11 to 0.11.1

The first issue has been fixed in the repository -- postpone ticket to 0.11.1 for the jQuery rewrite, I think it would be too invasive at this point in the 0.11 release.

  Changed 7 months ago by jruigrok

  • milestone changed from 0.11.1 to 0.12

After talking with Jonas it would be better to put it for 0.12.

in reply to: ↑ 4   Changed 7 months ago by cboos

Replying to jruigrok:

The first issue has been fixed in the repository

To what change do you refer?

  Changed 5 months ago by cboos

  • keywords query jquery javascript added
  • owner set to cboos
  • milestone changed from 0.13 to 0.12

Add/Change #7111 ('checkbox' filter options are created as radio buttons a vise-versa)

Author



Change Properties
<Author field>
Action
as new
as The resolution will be set. Next status will be 'closed'
to The owner will change from cboos. Next status will be 'new'
The owner will change from cboos to anonymous. Next status will be 'assigned'
 
Note: See TracTickets for help on using tickets.