[Patch] Query module column reordering

[ebray]

This is a patch I came up with at PyCon specifically because some of my users need it, but I think something like it could go into Trac core.

First of all it solves the problem of the poor scalability of the UI for selecting columns to display, which is pretty unusable in situations where there are something on the order of 50 custom fields (which I've seen, and it's ugly).

I also needed the ability to let users reorder the columns, which this solves. I'm not sure how the Trac devs will feel about this. It replaces the 'col=' query arguments with arguments in the form 'col#=', where # is the order that that column should be displayed in. This works fine for URL query strings. But I haven't updated the TracQuery syntax to support column reordering. Other than that it seems to work fine, and includes support for non-JavaScript users.

[hyugaricdeau@…]

Some of the diffs may be from my editor removing stray whitespace, which may be annoying.

[hyugaricdeau@…]

Forgot to set all the other fields, oops.

[cboos]

I tried the patch and it works great. I think the UI is perfect for the non JavaScript case, but with JavaScript enabled, I'm sure we could even make this more intuitive in the future by providing the possibility to simply dragg the column name up and down.

I'm not sure about passing the ordering info (coln). Currently, we simply rely on the order of the col arguments in req.args['col'] to be the same as they appear in the query string. Is there a situation were this wouldn't work? If not, I think the code could be simplified a lot. At the very least, the col parameters without a number should still be supported for backward compatibility and for example, added at the end after the numbered columns.

[ebray]

I didn't know that arguments of the same name were guaranteed to appear in the list in the same order that they appear in the query string. But if so, then that definitely simplifies matters greatly. I'll have to try it out and see what I can come up with.

I thought I did maintain backwards compatibility by listing col arguments after the coln arguments. But maybe I just thought it but never did it. Oh well, if the above is true then it's a moot point.

Dragging of columns would definitely be nice, but that would probably make sense to do once jQuery UI is included with Trac, which there seems to be some talk about doing.

[ebray <hyugaricdeau@…>]

Simplified patch without modifying url query strings.

[ebray <hyugaricdeau@…>]

Here's a much simpler version of the patch that does not depend on the coln query string arguments, as long as the col= arguments are listed in order it works fine.

[ebray <hyugaricdeau@…>]

Simplified patch without modifying url query strings.

[ebray <hyugaricdeau@…>]

Ignore the previous attachment. I did the diff on the wrong directory.

[ebray <hyugaricdeau@…>]

Ignore that version of the patch too.. It had a weird stray line left in it. This is the one you want.

[ebray <hyugaricdeau@…>]

An updated version of this patch with a somewhat improved implementation. The UI for adding and removing columns is now more similar to the UI for adding/removing filters.