Edgewall Software

Ticket #6821 (closed defect: fixed)

Opened 11 months ago

Last modified 11 months ago

Better patch to fix #5783

Reported by: amax@… Owned by: cboos
Priority: normal Milestone: 0.10.5
Component: general Version: 0.10.4
Severity: normal Keywords: mysql
Cc:

Description

Hi,

Earlier we contributed a patch to solve #5783, which was accepted and merged into trunk. With more experience, we have found the attached patch to be better. The first patch solved the original bug most of the time, but it did sporadically show up again. This new patch is more thorough; we've used it for about four months, and so far (knock on wood) the error has not reoccurred.

This try-catch approach was considered at one point (if you dig into the mailing lists), but at the time it appeared not to be necessary. I think now that it is.

-Aaron

Attachments

trac_better_mysql_fix.diff (0.6 KB) - added by amax@… 11 months ago.
patch: purportedly better fix for #5783
trac_better_mysql_fix.2.diff (0.8 KB) - added by amax@… 11 months ago.
patch: purportedly better fix for #5783 (previous upload of this name was incorrect, this one is the right patch)

Change History

Changed 11 months ago by amax@…

patch: purportedly better fix for #5783

Changed 11 months ago by amax@…

patch: purportedly better fix for #5783 (previous upload of this name was incorrect, this one is the right patch)

Changed 11 months ago by anonymous

Just to clarify, the patch labeled trac_better_mysql_fix.diff is not correct. My mistake - I uploaded the wrong patch. The correct patch is trac_better_mysql_fix.2.diff .

Changed 11 months ago by cboos

  • keywords mysql added
  • owner changed from jonas to cboos
  • status changed from new to assigned
  • milestone set to 0.10.5

Thanks for the patch!

Changed 11 months ago by cboos

  • status changed from assigned to closed
  • resolution set to fixed

Applied in r6510 for trunk and r6511 for 0.10.5dev.

I removed the non-global import MySQLdb statements, which IIRC also can lead to trouble. I tested the modified patch on trunk, but not on 0.10.5dev, I hope everything is right there.

Add/Change #6821 (Better patch to fix #5783)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cboos. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.