Extended 'view diff' feature does not update the browsing position

[eblot]

When a changeset is browsed (/changeset/xxx) and that the max size/file limit is reached, the changeset diff is not rendered: only the changeset log message and the list of modified files are rendered. This is the expected behaviour.

A handy feature is that each modified file appears in the list with a "view diff" clickable link. When such a link is selected, the diff of the file is rendered, again with the log message of the same changeset.

However the browser shows the regular diff page, without scrolling down to the actual diff section.

When the log message is a bit long, the user experience is a bit weird: it seems that the link led to the same page as the full changeset: the same long log message is rendered, and the selected diff does not appear in the browsing window.

It would be nice to add an anchor to the diff section so that the browser directly jump to the actual diff, that is the info he selected from the changeset view.

[cboos]

What you suggest sounds a reasonable thing to do, as a first step.

As as second step, we might want to have in-place expansion of those diffs ;-)

(oh, didn't even notice it was you manu ;-) )

[eblot]

Replying to cboos:

(oh, didn't even notice it was you manu ;-) )

Will you believe it tooks me a couple of minutes to figure out what's going on with those diffs ? ;-)

In-place diff with AJAX would be even better, I did not think about this feature, you're right.

Another note (OOT) about diff: the tabular vs. unified button seems a bit awkward: the user needs to click on a grayed button to activate the alternative view mode - grey UI items are normally used to depict a disabled feature. I have no alternative proposition in mind but it could be improved using another color, at least. Thanks.