Edgewall Software

Ticket #6635 (closed defect: fixed)

Opened 12 months ago

Last modified 10 months ago

/prefs/datetime should default to server TZ

Reported by: Daniel Kahn Gillmor <dkg-debian.org@…> Owned by: jruigrok
Priority: normal Milestone: 0.11
Component: i18n Version: 0.11b1
Severity: normal Keywords: timezone
Cc:

Description

On a trac 0.11b1 setup with pytz installed, when a user goes to set their TZ preferences for the first time (at /prefs/datetime), they are confronted with a default choice of Asia/Qatar.

It would be more reasonable if they were given a default choice that matched the server's default time zone.

Attachments

6635-fix.diff (3.0 KB) - added by Daniel Kahn Gillmor <dkg-debian.org@…> 12 months ago.
Fix to default users to server local time zone if they have no time zone set.

Change History

Changed 12 months ago by Daniel Kahn Gillmor <dkg-debian.org@…>

Probably even simpler to implement: the user could be given an explicit "Server Default" choice which would remove the matching name=tz row in the session_attribute table.

Changed 12 months ago by Daniel Kahn Gillmor <dkg-debian.org@…>

Fix to default users to server local time zone if they have no time zone set.

Changed 11 months ago by jruigrok

  • owner changed from jonas to jruigrok
  • status changed from new to assigned

Changed 11 months ago by jruigrok

  • milestone set to 0.11

This is indeed annoying, looking into it.

Changed 11 months ago by intgr

I've applied this patch and it seems to work.

But when the user clicks "Save changes" with the setting unchanged ("Default time zone" chosen), it goes right back to Asia/Seoul again.

Changed 11 months ago by jruigrok

  • component changed from general to i18n

Changed 11 months ago by jruigrok

The current patch does indeed have some issues. Need to dig into it...

Changed 10 months ago by jruigrok

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in r6689 with a slightly altered patch and another fix to Trac.

Add/Change #6635 (/prefs/datetime should default to server TZ)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from jruigrok. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.