Wiki blame support

[thatch]

One feature we never got implemented into the blame branch from 2006 was blame support for wiki pages. I now have a straw-man implementation for review. Please give this patch a try on your 0.11-dev install and specifically let me know:

• Does it produce correct blames on your pages?
• Is it fast enough?
• Should there be a new permission for annotations? some meta tags to disallow robots?
• Should there be something more like an IBlameAnnotator with callbacks for rev links, or is this best handled through the existing IHTMLPreviewAnnotator? I could see a lot of possibility for reuse if we eventually have versioned tickets and vc backends that don't support blames natively.

[cboos]

Glad to see you've resumed work on that!

• correct blame - hm, difficult question, maybe even out of scope ;-) If needed, the blame algorithm could always be fixed/improved later on, let's focus on the integration of what we have now.
• fast enough - seems to be. On a medium-sized page with 130 revisions, the rendering speed of normal vs. annotate is quite the same. On a pathologically big page with 50 revisions, the slow down is acceptable (comparable to what we have for versioncontrol annotate).
• new permission? no, I don't think so. meta tags? yes, the same as for versioncontrol annotate
• IBlameAnnotator - I'd prefer generalizing the BlameAnnotator from browser.py and make it work on other versioned resources (would be a 0.12 topic)

[athomas]

From an IRC discussion:

thatch: some way to navigate through the page history would be good i think
and it'd be nice if the version links had title="author + comment" or similar
which are all minor nits really

<thatch> you say "navigate", like a prev/next link up top, or something like "re-annotate before this rev" in the left column?

prev/next links, but maintaining the annotation view
also, i'd ditch the other links like "start page", "index", etc. similar to how it works when you're browsing the page history

[cboos]

Tim, was it task on purpose? I'd rather see this as being an enhancement.

[thatch]

Alright, enhancement it is. I'm working on this in source:/sandbox/wiki-blame to take care of the additional suggestions in this ticket.

[cboos]

Where's the WikiBlame? page? :-)

[thatch]

Replying to cboos:

Where's the WikiBlame? page? :-)

Try TracDev/Branches/WikiBlame as of today.