Edgewall Software

Ticket #5795 (closed defect: fixed)

Opened 18 months ago

Last modified 17 months ago

No diff output when "White space changes" is checked

Reported by: r.sokoll@… Owned by: thatch
Priority: normal Milestone: 0.11
Component: wiki system Version: devel
Severity: trivial Keywords:
Cc:

Description

I changed a wiki page from

* some text

to

 * some test (note the leading space)

Now, if I want to see the diff and "White space changes" is checked, there is no diff at all.

Trac 0.11dev-r5883

Attachments

Diff.png (7.0 KB) - added by r.sokoll@… 18 months ago.

Change History

Changed 18 months ago by thatch

  • status changed from new to closed
  • resolution set to invalid
  • component changed from version control to wiki

Assuming the 'text' -> 'test' is a typo in the report, this is precisely what "ignore whitespace changes" is supposed to do.

Closing as invalid, feel free to reopen if there's a larger issue here.

Changed 18 months ago by r.sokoll@…

  • status changed from closed to reopened
  • resolution invalid deleted

It was a typo, of course. But, if this behavior is expected, then the diff output (without "White space changes") is wrong, see the screenshot. The leading space is missed. You may adopt the subject of this ticket, of course.

Changed 18 months ago by r.sokoll@…

Changed 18 months ago by thatch

Oh, indeed it's wrong for me too (Firefox 2). It is only wrong in the tabular view, it's correct in the unified view. The source looks okay too, there's a <ins> </ins> in there. I'm not quite sure where it's getting lost.

Changed 18 months ago by r.sokoll@…

What about <ins>&nbsp;</ins> instead of <ins> </ins>?

You may handle this as a cosmetic issue :-)

Changed 18 months ago by ThurnerRupert

  • severity changed from minor to trivial
  • milestone set to 0.11

change to trivial if this is cosmetic ...

Changed 17 months ago by thatch

  • owner changed from cboos to thatch
  • status changed from reopened to new

Changed 17 months ago by thatch

  • status changed from new to closed
  • resolution set to fixed

Fixed in r5888 for 0.11-dev

Add/Change #5795 (No diff output when "White space changes" is checked)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from thatch. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.