Edgewall Software

Ticket #4312 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Attachment to ticket in timeline lacks title for ticket reference

Reported by: Tim Hatch <trac@…> Owned by: cboos
Priority: normal Milestone: 0.11
Component: timeline Version: devel
Severity: trivial Keywords: attachment
Cc:

Description

For example, I see on the timeline right now <em>timeline_spelling.patch</em> attached to ticket <em>#4310</em>. I'm used to having a tooltip over things on the timeline that have a ticket reference, like for ticket changes, Ticket <em title="Ticket Title">#4310</em>....

This patch does it just for tickets by modifying the display callback. I'm not sure about the speed penalty.

  • trac/ticket/web_ui.py

     
    545545            # Attachments 
    546546            if 'ticket_details' in filters: 
    547547                def display(id): 
    548                     return html('ticket ', html.em('#', id)) 
     548                    return html('ticket ', html.em('#', id, title=Ticket(self.env, id)['summary'])) 
    549549                att = AttachmentModule(self.env) 
    550550                for event in att.get_timeline_events(req, db, 'ticket', 
    551551                                                     start, stop, display): 

Observed on t.e.o and reproduced on trunk.

Attachments

Change History

Changed 2 years ago by cboos

  • keywords attachment added
  • owner changed from jonas to cboos
  • severity changed from normal to trivial
  • milestone set to 0.11

Well, this introduces no more overhead than if that would have been a regular comment for that ticket, so I guess it's OK.

Changed 2 years ago by cboos

  • status changed from new to closed
  • resolution set to fixed

Added in r4391.

Add/Change #4312 (Attachment to ticket in timeline lacks title for ticket reference)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cboos. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.