Submit button missing when editting read only wiki pages

[PBruin]

I have just upgraded my stable 0.10 version from r4050 to r4171
The problem I face is that when I try to edit a read-only wiki page the Preview Submit and Cancel buttons are missing. The same happens when I create a new page and make it read-only and then press Preview. No buttons are visible.

[PBruin]

I confirm that reverting back to r4050 resolves the issue

[PBruin]

Sorry, I mean r4041, the other one was the trunk version I used before going back to the stable 0.10-stable branch.

[PBruin]

I have done some testing, when using r4144 I can still Submit my changes, with r4145 the submit button has gone.

[PBruin]

Actually, not just the buttons are missing. The whole footer is missing.

[PBruin]

html generated for page without footer and buttons with r4145

[PBruin]

html generated for page that is not checked as read only with r4145

[PBruin]

I have added two files that contain the same page when I click preview. Once I have the read-only box checked and the other time not. This was tested on 0.10-stable without any plugins or other additions.

[cboos]

Well, it's too late for milestone:0.10.1 which has been released. Can you try again with that released version or at least r4155, to check if the problem is still present with the latest incarnation of the CSRF fix?

[cboos]

Ah, wait, it's probably related to r4184, so yes, try again with the released milestone:0.10.1 ...

[jonas]

This was probably fixed by r4184. Either update to the latest 0.10-stable or the 0.10.1 release.

[PBruin]

Ok, this fixes it for this test site. However, my main site has the th:wiki:TracBlogPlugin setup and there it is still present. They use the same installation and I have the plugin in the local configuration of that site. Any tips or do I need to take this to Trac-Hacks?

[cboos]

Are you sure you have restarted your main site, and does disabling the plugin "fix" the issue?

[PBruin]

Both run on the same apache server. These are the two config I used. First one works, then to test I changed back to the second one and the problem is back.

[components]
acct_mgr.* = enabled
tblog.* = disabled
trac.wiki.web_ui.wikimodule = enabled
tracchangelog.* = enabled
tractags.* = enabled
webadmin.* = enabled

---

[components]
acct_mgr.* = enabled
tblog.* = enabled
trac.wiki.web_ui.wikimodule = disabled
tracchangelog.* = enabled
tractags.* = enabled
webadmin.* = enabled

[PBruin]

Got it. It was due to the th:wiki:TagsPlugin as this had the same problem as was fixed in wiki.cs in r4184. Thanks for your help!

[cboos]

It's a bit strange though, as from what you posted in comment:11, the tractags plugin was enabled in both configurations...

[PBruin]

Correct. But the wiki module was not disabled. The tags plugin uses its own wiki module to display the tags in the page and on the edit properties as you can see in this file. I have attached the fixed file to the th:wiki:TagsPlugin page for people to use.

[athomas]

I've updated th:wiki:TagsPlugin, thanks for the patch.

[byrnejb@…]

We are running trac-0.10.2 as released via the CentOS-4 team and have this problem with read only pages.

[byrnejb@…]

Supplemental correction to above. The repository that provided us with the trac-0.10-2 rpm that wee are using is actually found at http://dag.wieers.com/packages/trac/

[byrnejb@…]

It has been six weeks since this issue was reopened. Is there any hope of a repair release or a patch to 0.10.2 in the very near future? If not, then how does one revert to an earlier version?

[Noah Kantrowitz <coderanger@…>]

Replying to byrnejb@harte-lyne.ca:

It has been six weeks since this issue was reopened. Is there any hope of a repair release or a patch to 0.10.2 in the very near future? If not, then how does one revert to an earlier version?

Are you absolutely sure you are using the default wiki module?

[thatch]

Also, have you tried upgrading to the trac-0.10.3-1 which is available in that repository you mentioned?

[mgood]

Replying to byrnejb@harte-lyne.ca:

It has been six weeks since this issue was reopened. Is there any hope of a repair release or a patch to 0.10.2 in the very near future? If not, then how does one revert to an earlier version?

I've checked the contents of the Trac 0.10.2 RPM and it contains the fix from r4184, so this is most likely due to the use of the th:TagsPlugin as mentioned above. You will need to upgrade this plugin to fix the issue.

[byrnejb@…]

I removed TracTags? many months ago because I could never get it to work. There is nothing to upgrade and, as far as I can see, nothing in the trac.ini file that references any of trhe TracTags? components except a few comments preserving some of the former settings. I have removed these and altered the trac.ini file to conform with the recommendations of the trac project "trac.ini wiki page. Restarting the httpd server following these changes did not correct the problem.

I was unaware that Dag had updated trac to 0.10.3 (on last Wednesday, Dec. 13). I will apply this update directly and see if this fixes the problem.

[byrnejb@…]

I have updated to 0.10.3 and restarted the httpd server. The missing submit buttons have not returned for the read-only pages. I can edit, but I cannot save changes. If this is an artifact of the previous tractags plugin then I would really appreciate some guidance as to how to rid myself of all traces of this component.

[byrnejb@…]

I decided that perhaps I would try to re-install tractags and see if that cleared the problem. The difficulty I now face is that the link to TracTags? given on the plugins wiki page is defunct as is any reasonably discernible variant. Where is the most recent TracTags? plugin found?

[Noah Kantrowitz <coderanger@…>]

Double check that you do not have any local modifications to the wiki template (possibly in <env>/templates/wiki.cs).

A copy of the tags plugin page can be found here.

[byrnejb@…]

Yes! That was the problem. The earlier install of TracTags? must have modified the wiki.cs because its fingerprints were all over the version I had in templates. Copying over the default version of wiki.cs cured the problem.

[mgood]

Ok, good. It looks like the fix for Trac was originally released in 0.10.1.

[anonymous]

Isn't that the whole point of having a readonly page?

[anonymous]

I think that a read only page should be editable only by user with a TRAC_ADMIN permission.