Notifications use field name instead of label for custom fields

[jflorian@…]

While it is very nice to have the custom fields appear in the notification mail, it would be better if they used the label given to them instead.

Often the field name is an abbreviation that can be quite confusing for most of our users whereas the labels would be something they'd recognize immediately.

[jflorian@…]

Sorry, forgot to set the version to what we're actually using.

[trac_dev at mail.ru]

add to cc

[osimons]

It is exactly as we do it on the regular fields also for web ui, so either we need to change the current practice for all fields, or else this won't make sense.

However, with current i18n effort underway, I suppose this is also related to that as it for many will make the default labels and fieldnames very different. Currently all labels and field names are the same (except capitalization) - that won't be the case later.

[cboos]

... not to mention the fact that currently it's the same mail sent to everyone, and that with i18n we probably need to partition the recipient list according to their language and send as many differently translated mails as needed.

[cboos]

#6854 was closed as duplicate

[hju@…]

while localization is an very interesting feature, I'm much more interested on the basic defect Notifications use field name instead of label for custom fields at the moment. It's exactly what I was looking for at the moment.

[hju@…]

Taking a brief look in the code, I implemented a little patch to change to label instead of names for all fields in notification.

Its not the overall solution, just a "hard change" to label.

The patch concerns notification.py:

trac/ticket/notification.py

@@ -156 @@
-         for f in [f['name'] for f in fields if f['type'] != 'textarea']:
-             if not tkt.values.has_key(f):
+         for f in [f for f in fields if f['type'] != 'textarea']:
+             if not tkt.values.has_key(f['name']):
                  continue
-             fval = tkt[f]
+             fval = tkt[f['name']]
              if fval.find('\n') != -1:
                  continue
              idx = 2 * (i % 2)
-             if len(f) > width[idx]:
-                 width[idx] = len(f)
+             if len(f['label']) > width[idx]:
+                 width[idx] = len(f['label'])
              if len(fval) > width[idx + 1]:
                  width[idx + 1] = len(fval)
              i += 1
@@ -175 +176 @@
          for f in [f for f in fields if f['name'] != 'description']:
              fname = f['name']
+             flabel = f['label']
+             if not flabel:
+                 flabel = fname
              if not tkt.values.has_key(fname):
                  continue
              fval = tkt[fname]
              if f['type'] == 'textarea' or '\n' in unicode(fval):
-                 big.append((fname.capitalize(), CRLF.join(fval.splitlines())))
+                 big.append((flabel.capitalize(), CRLF.join(fval.splitlines())))
              else:
-                 txt += format[i % 2] % (fname.capitalize(), fval)
+                 txt += format[i % 2] % (flabel.capitalize(), fval)
                  i += 1

The patch ist not overall tested, but implemented in our environment (0.11) an running properly (till now).