Edgewall Software

Ticket #3865 (reopened defect)

Opened 2 years ago

Last modified 3 months ago

Document migration to site.html

Reported by: sam@… Owned by: cmlenz
Priority: normal Milestone: 0.11.3
Component: general Version: devel
Severity: normal Keywords: initenv inherit
Cc: m@…, trudolphi@…

Description

The files in env/templates/... are not used, thus making CSS or templates tweaks per-environment impossible with latest Trac trunk. This is clearly a regression from previous revisions.

Attachments

disable_env_site_template.patch (0.6 KB) - added by shanec@… 3 months ago.
only create site.html if one is not in shared template path

Change History

  Changed 2 years ago by cboos

Strange, seems to be still there, in Chrome's get_templates_dir.

follow-up: ↓ 3   Changed 2 years ago by cmlenz

  • priority changed from high to normal
  • severity changed from major to normal

Well, the Clearsilver site_*.cs are no longer used if the page is being rendered using Genshi. Instead, env/templates/site.html is being included if it's present.

We obviously need to add some upgrade instructions for guiding with the migration here.

in reply to: ↑ 2   Changed 2 years ago by Markus Tacker <m@…>

  • cc m@… added

Replying to cmlenz:

We obviously need to add some upgrade instructions for guiding with the migration here.

Yes, please do so!

  Changed 2 years ago by cboos

See also googlegroups:trac-dev:f4200982343077f3

  Changed 2 years ago by cmlenz

  • keywords documentation added
  • owner changed from jonas to cmlenz
  • status changed from new to assigned
  • summary changed from User templates not loaded to Document migration to site.html

And this post, which would be a starting point for updates to TracInterfaceCustomization.

  Changed 2 years ago by Markus Tacker <m@…>

  • cc trudolphi@… added

  Changed 19 months ago by cboos

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone changed from 0.11.1 to 0.11

I believe this was fixed by r5703.

Changed 3 months ago by shanec@…

only create site.html if one is not in shared template path

  Changed 3 months ago by shanec@…

  • status changed from closed to reopened
  • resolution fixed deleted

I ran into an issue where the shared template site.html *was not* being used. When creating an environment, a site.html file is written out into env/template. If I remove that, the shared site.html is used. The patch I just attached does not write out a env/template/site.html if one exists in the shared template dir.

  Changed 3 months ago by cboos

  • keywords initenv inherit added; documentation removed
  • milestone changed from 0.11 to 0.11.3

Seems in line with what we do for other settings when using the --inherit flag for creating new environments (TracAdmin#Notes).

Rescheduling to 0.11.3, for integrating attachment:disable_env_site_template.patch.

Add/Change #3865 (Document migration to site.html)

Author



Change Properties
<Author field>
Action
as reopened
as The resolution will be set. Next status will be 'closed'
to The owner will change from cmlenz. Next status will be 'new'
 
Note: See TracTickets for help on using tickets.