When a ticket version is deleted, it does not show what the deleted value was

[sid@…]

The text shown in the ticket comment is just "Version deleted", but if you want to add back the original value, there is no way to know what to change it back to.

[cboos]

That's not specific to Version. We could possibly put that information in a tooltip. Alternatives could be:

• version 0.10 deleted
• version deleted (was 0.10)

But putting the old value in clear text as above could be mistaken for a set to..., when scanning rapidly.

[sid <sid.wiesner@…>]

Strange, I never got an email update from this ticket.

Anyway, I think adding to a tooltip is good. I just would like a way to see the previous version. This might be nice for the other fields as well, but could be problematic if you tried it with the description field.

[Noah Kantrowitz (coderanger) <coderanger@…>]

Also if you have TicketDelete? installed, that shows the full content of all changes.

[Remy Blank <remy.blank@…>]

Is this feature still desired? If yes, I would like to try and provide a fix.

If I understand the comments above, the old value could be either provided inline or in a tooltip. As any other changes are reported inline (in particular, "changed from ... to ..."), it would probably be more consistent to display the previous value inline. Personally, I like the format "deleted 0.10".

Please let me know which solution is preferred, and I'll start working on it.

[cboos]

What do you mean by "deleted 0.10"?

1. milestone deleted 0.10
2. milestone 0.10 deleted
3. milestone deleted (was 0.10)
4. milestone deleted

I think 1. looks funny, I'm afraid 2. and 3. can be mistaken for a "set" (but maybe that's just me). 4. (with the tooltip) is fine except when printed out (we may tweak the css to show more when printing, but I'm not sure it's worth the added complexity).

[Remy Blank <remy.blank@…>]

Replying to cboos:

What do you mean by "deleted 0.10"?

1. milestone deleted 0.10

Yes, that's what I meant. It does look funny, but I thought that this would be the most consistent with the other "events". Or what about "deleted from ...":

• milestone set to 0.10
• milestone changed from 0.10 to 0.11
• milestone deleted from 0.11

Mmh, not really correct English, I guess...

4. (with the tooltip) is fine except when printed out (we may tweak the css to show more when printing, but I'm not sure it's worth the added complexity).

I would rather not use a tooltip, as it is not consistent with the way the other changes are reported.

I'll start with the "deleted (was ...)" version above, and we can tweak the string formatting after having looked at a few real-world samples.

[ebray <hyugaricdeau@…>]

I agree with Remy-- "deleted (was...)" makes the most sense. I think if it's italicized or something it would help in scanning. It's really the most clear option, and doing stuff with tooltips and CSS makes it more complicated than necessary.

But it would definitely be nice to have this. It's particularly useful for when ticket vandalism occurs.

[Remy Blank <remy.blank@…>]

Patch against 0.11-stable showing the removed content in ticket property changes

[Remy Blank <remy.blank@…>]

I finally implemented the following version:

• milestone 0.11 deleted

Indeed, this is how reporter or owner deletion was already displayed (see bottom of TicketModule._render_property_diff()).

The same change was also added to the ticket RSS feed.

[cboos]

Looks really good like that and indeed it was already done for owner ...

Patch applied in r7382.