Edgewall Software

Ticket #3410 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

No way to inline an image URL

Reported by: athomas Owned by: cboos
Priority: normal Milestone: 0.10
Component: wiki system Version: devel
Severity: normal Keywords:
Cc:

Description

Previously, simply inserting an image URL would inline the image. This has recently changed (not sure why?) and it no longer seems possible to display URL images inline at all. [[Image(<url>)]] does not work either, as it appears to only accept attachments.

Attachments

Change History

Changed 2 years ago by eblot

Alec, I think this is a duplicate of #3374.

It seems however that using a URL instead of the Image macro is a regression, as it is not possible to define style for this kind of image (position, size, ...). I might be wrong.

Changed 2 years ago by athomas

That ticket is related, but not a duplicate.

The crux of the matter is that it is no longer possible to display images by URL. Ideally the Image macro would do this.

Changed 2 years ago by cboos

  • owner changed from jonas to cboos
  • component changed from general to wiki
  • milestone set to 0.11

The code in the Image macro could be cleaned-up and simplified, I have a few ideas about it, but this will have to wait for 0.11.

Changed 2 years ago by athomas

Should this really wait until 0.11? Inlining images seems like a fairly fundamental thing, particularly as it used to work.

Changed 2 years ago by cboos

Well, yes a quick solution for adding http: could be done for 0.10.

I was talking about a more general solution for interpreting any kind of links, using wiki_to_link or similar, and that should wait for 0.11.

Changed 2 years ago by cmlenz

  • milestone changed from 0.11 to 0.10

Oh, I thought the [[Image]] macro supported external URLs. That's what this ticket is about, so let's fix it for 0.10.

Changed 2 years ago by cboos

  • status changed from new to closed
  • resolution set to fixed

Ok, implemented in r3533.

Changed 2 years ago by simon-code@…

  • status changed from closed to reopened
  • resolution fixed deleted

Just reviewed and tested the changeset at [3533]. There is an external linktype I'm missing for much of our use - https:

Would it be OK to change the lines in question to:

                elif id in ('http', 'https', 'ftp'): # external URLs
                    raw_url = url = desc = id+':'+file

Changed 2 years ago by cboos

  • status changed from reopened to new

Yeah, ok but after that, let's wait for the much needed refactoring of the wiki parser and macros ;)

Changed 2 years ago by cboos

  • status changed from new to closed
  • resolution set to fixed

https: added in r3549.

Add/Change #3410 (No way to inline an image URL)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cboos. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.