Edgewall Software

Ticket #3060 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Broken download link in Source-Browser

Reported by: anw@… Owned by: cboos
Priority: high Milestone: 0.10
Component: version control/browser Version: devel
Severity: minor Keywords:
Cc:

Description

In r3213 the donwload link in the sourecbrowser for non-previewable files is broken. the cs var:file.raw_href in the browser.cs template is empty. Putting 

req.hdf['file.raw_href'] = raw_href

after 

# add ''Original Format'' alternate link (always)
            raw_href = req.href.browser(node.path, rev=rev, format='raw')

in line 249 would fix this.

Attachments

Change History

Changed 3 years ago by cboos

  • owner changed from jonas to cboos
  • priority changed from normal to high
  • status changed from new to assigned
  • severity changed from normal to minor

Oops, sorry. That was the job of the preview_to_hdf method, and there, I have to add the raw_href in all cases (not only when the max_preview_size is reached).

Changed 3 years ago by cboos

  • status changed from assigned to closed
  • resolution set to fixed

Should be fixed by r3212.

Changed 3 years ago by cboos

(r3214 I meant, sorry)

Add/Change #3060 (Broken download link in Source-Browser)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cboos. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.