trac-admin hotcopy broken, unicode related problem

[sam@…]

Running trac-admin hotcopy fails with the following error :

Command failed: unicode() argument 2 must be string, not None

Trac trunk/, fresh update.

[cboos]

Probably sys.stdin.encoding which is None for you.

Can you try this patch?

Index: admin.py
===================================================================
--- admin.py	(revision 3118)
+++ admin.py	(working copy)
@@ -90,7 +90,7 @@
         """`line` may be a `str` or an `unicode` object"""
         try:
             if isinstance(line, str):
-                line = unicode(line, sys.stdin.encoding)
+                line = util.to_unicode(line, sys.stdin.encoding)
             rv = cmd.Cmd.onecmd(self, line) or 0
         except SystemExit:
             raise

[sam@…]

Works like a charm.

[cboos]

Well, can you also try to create a new Milestone using trac-admin, "avé les assents" :)

I suspect there could be a problem there if sys.stdin.encoding is not known. It could then be worth to print a warning.

(+ what's your python version/platform?)

[sam@…]

Creating a milestone with an accent worked without warnings (in interactive mode).

Python 2.3.5 (#2, Mar  6 2006, 10:12:24) 
[GCC 4.0.3 20060304 (prerelease) (Debian 4.0.2-10)] on linux2
Linux frog 2.6.11-grsec #3 Sun Mar 6 20:05:04 CET 2005 i686 GNU/Linux

[cboos]

OK, and in Trac, the accent shows up correctly?

[sam@…]

Affirmative!

[cboos]

Also fixed by mgood in r3140 in order to solve #3030.