unable to upload files which filename is non-english characters

[anonymous]

With 0.10dev, while attaching a filename in asian-characters. Attachment function is broken. for example, 中文.txt became %E4%B8%AD%E6%96%87.txt and attachment link were unable to locate this file.

[cboos]

While trying out with european accented characters on Windows, I also had some issues, but different ones. I've fixed them in r3103.

Can you test if this works for asian characters too?

[anonymous]

thanks, r3103 is now working with asian filenames.

[bitneer@…]

attachement problem

• Trac 0.10dev(revision 3416) on Windows XP
• korean filename: example) 한글.txt

error message

Traceback (most recent call last):
  File "C:\Python23\Lib\site-packages\trac\web\main.py", line 314, in dispatch_request
    dispatcher.dispatch(req)
  File "C:\Python23\Lib\site-packages\trac\web\main.py", line 163, in dispatch
    if not req.path_info or req.path_info == '/':
  File "C:\Python23\Lib\site-packages\trac\web\api.py", line 193, in <lambda>
    path_info = property(fget=lambda self: self.environ.get('PATH_INFO', '').decode('utf-8'),
UnicodeDecodeError: 'utf8' codec can't decode byte 0xa2 in position 31: unexpected code byte

[mgood]

The byte 0xa2 is not in the example filename you mentioned. I've tested the example filename on different Trac setups and it works fine. I also tested a filename with the character for 0xa2 "¢", which works fine as well. What web server are you using, and which Trac frontend (FastCGI, mod_python, CGI)? It looks like it must be encoding the PATH_INFO variable incorrectly.

[bitneer@…]

I'm using

• Apache 2.0.58 for Windows
• CGI for Trac frontend

[mgood]

I can't reproduce this with the current information. Postponing until after the 0.10 release. This could get bumped up to 0.10.1 once we have that milestone.

[cboos]

I think it's the same issue as #3663.

[Blackhex]

I think that problem is in getting filename of uploaded file from request. I'm trying to upload files within ScreenshotsPlugin? using this:

file = req.args['file']
filename = file.filename

The filename object is then of type str and should be of type unicode, should't it?

[eblot]

Replying to Blackhex:

I think that problem is in getting filename of uploaded file from request. I'm trying to upload files within ScreenshotsPlugin? using this:

Which file/version are you refering to?

[nkantrowitz]

I traced the error to trac.web.api.Request._parse_args, and it affects both 0.10-stable and trunk. In short, non-file arguments (i.e. most of them) are decoded as UTF8 text there, but filenames are left alone. These should be decoded as well.

[anonymous]

Replying to eblot:

Which file/version are you refering to?

I'm working with 0.10.3 but coderanger said me that code handling argskey?.filename is not changed in trunk since 0.10.3.

[eblot]

I can't reproduce this issue with the latest trunk, using tracd on a Mac OS 10.4.10. I tried with the same machine as the client (OmniWeb/WebKit), as well as with a virtualized Linux/Ubuntu 7.04 (Firefox 2.0.0.3), using the proposed korean 한글.txt and chinese(?) 中文.txt filenames.