Edgewall Software

Ticket #157 (closed defect: fixed)

Opened 5 years ago

Last modified 2 years ago

Fine grained permissions

Reported by: anonymous Owned by: utopiste
Priority: normal Milestone: 0.8.1
Component: general Version: 0.6
Severity: normal Keywords: permission
Cc: pbaker@…

Description

We should (somehow) support more fine grained access control, a'la mod_authz_svn.

In fact, the configuration file format for authz is trivial, if not even directly compatible with python's configfile parser... We could maybe use that directly, that'd be quite easy to set up.

Attachments

mod_authz_perm_p1.patch (6.7 KB) - added by Utopiste 5 years ago.
First patch for mod_authz support
mod_authz_perm_p1.2.patch (9.3 KB) - added by utopiste 5 years ago.
work on trunk, initial changeset support

Change History

Changed 5 years ago by ben

  • version changed from 0.5.2 to 0.6
  • severity changed from normal to major

i just wanted to add that this missing feature can be a real showstopper. we're using subversion as a service for computer science projects or bachelor/master thesises at my university and these get stored in one repository with usage of mod_authz for fine grained permissions. the problem is not the browser itself which could certainly have some kind of access control via apache, but with the changesets in the timeline this is simply not possible. this way it is possible to look into source codes or thesises without having the proper permission. as a result it is not possible to use trac in a configuration like we have which is really a pity!

Changed 5 years ago by anonymous

  • priority changed from normal to high

Not to mention if you are using it commercially.... Let's just say all the beneifts of providing external access to this cool tool would be much more than negated. This is the only showstopper I see so far, to our usage.

Changed 5 years ago by jonas

  • milestone set to 0.8

Changed 5 years ago by daniel

  • owner changed from jonas to utopiste
  • status changed from new to assigned

Changed 5 years ago by utopiste

For more information about this feature consult the FineGrainedPermissions page

Changed 5 years ago by anonymous

  • milestone changed from 0.8 to 1.0

Changed 5 years ago by utopiste

Oops... Trac detected an internal error: authz read privileges required to view this file

wouhou :) (ok currently only in File.py, but it's a beginning)

Primary release in few day

Changed 5 years ago by Utopiste

First patch for mod_authz support

Changed 5 years ago by jonas

Cool, I'm looking forward to this feature.

Changed 5 years ago by jonas

Duh, just noticed your patch. It looks nice, is this something you would like to have merged into trunk right now?

Changed 5 years ago by utopiste

work on trunk, initial changeset support

Changed 5 years ago by utopiste

Initial changeset support

work on the latest trunk

Changed 5 years ago by jonas

  • milestone changed from 1.0 to 0.8

Great work, moving this to 0.8

Changed 4 years ago by jonas

Patch merged into trunk.

A few comments:

  • It looks like the current authzperm.py only support sections of the format [repos-name:/path] and not [/path].
  • authz_file option in trac.ini should support relative filenames (relative to the env directory)
  • Should authz limit directory browser access as well?
  • It might be a good idea to load/parse the file when it's modified and not on every request. But ConfigParser? might be fast enough for us...

Changed 4 years ago by MishaS

I am checking trunk version of trac and it looks like the module does not seem to support authz groups.

Changed 4 years ago by pbaker@…

  • cc pbaker@… added

I have set up an authz access file for my trac installation and this feature does not seem to work. Nothing is logged to the trac.log about it. You should add some logging for when this feature is detected and used. That would really help out.

Changed 4 years ago by daniel

Should this be included in 0.8, or should we roll back the work so far and push it til 0.9?

How much work is still needed on this?

Changed 4 years ago by utopiste

one limitation fixed in [967]

It looks like the current authzperm.py only support sections of the format [repos-name:/path] and not [/path].

if no authz_module_name= config in the IniFile? we use /path style section

Changed 4 years ago by utopiste

  • keywords security added
  • priority changed from high to normal
  • severity changed from major to normal
  • milestone changed from 0.8 to 0.9

This feature can be used in the 0.8 release. i changed the milestone date to 0.9 because i have some more work to put inside this features (think group support and ACL caching) and i dont want to close this ticket.

FineGrainedPermissions was also updated to reflect this.

Changed 4 years ago by utopiste

initial Browser.py support in [968]

Changed 4 years ago by utopiste

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone changed from 0.9 to 0.8.1

with the last patch, should be enough stable to be used in the next version of trac

Changed 2 years ago by sid

  • keywords permission added; security removed

Add/Change #157 (Fine grained permissions)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from utopiste. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.