Highlight TracLinks in browser

[shad]

It would be nice to highlight TracLinks in browser file view, for example to display ticket links when viewing source:trunk/ChangeLog#latest.

[cboos]

This could be achieved by setting the svn:mime-type of the file to something like text/trac or application/x-trac...

Then, a mimeprocessor doing a wiki_to_html() could be used for rendering the file.

[cboos]

Idea above implemented in [1611]. This should be enough to correctly handle files like source:trunk/ChangeLog#latest.

Trying to detect TracLinks in all files would certainly be overkill...

However, one could add a post-processing step for enscript and/or ClearSilver highlighting, in order to look for TracLinks in the comments only. But this corresponds to a separate ticket, so I'm closing this one.

[cmlenz]

First, I don't think [1611] really addresses the request raised here. Are you expecting people to set the content type of their ChangeLog file to "text/x-trac-wiki" so that the ticket references get hyperlinked? Wouldn't that probably mess up the formatting of the change log?

Second, I don't see much value in the TracWikiRenderer personally, i.e. I don't really understand the use case. While the implementation surely is simple enough, I feel that it might be better provided by an option plugin, as opposed to part of the core functionality. But maybe you have some use cases in mind that I can't think of?

[cboos]

1. Is it really such a problem to set the mime-type on a file

in order to have it correctly highlighted? I can't see the problem here.

1. The use case is pretty simple: most of the projects contain

text documents like README, INSTALL.txt or such. Once developers are used to Trac's Wiki markup (because they are using the Trac Wiki for documentation purpose), they also tend naturally to use these conventions in other text documents. Then, while browsing those documents in Trac, it's also natural that they get formatted the expected way.

1. If that approach is not correct, how would you have addressed

this need, then?

[cmlenz]

The problem isn't setting the svn:mime-type property. The problem is that the files in question, for example README, ChangeLog or README.txt, are formatted as plain text. Treating them as if they contained Trac Wiki syntax will probably mess up the formatting. You argue that people will get used to using the Trac Wiki syntax and extend its use to the above files, which I doubt myself.

I'm not saying that I know a better solution to this request. I'm also not sure it's solvable in a "correct" way.

[shad]

I haven't tryed setting the svn:mime-type yet (simple and elegant solution), but I think cmlenz is right - we don't need full power of wiki in text-files (though it could mess the formatting of plain text file), just a link highlighting is required.

For simple plaintext files like ChangeLog there should be enough svn:mime-type property (someting like text/x-trac-links), but what about source files (c++ in my case) - sources often contain links to tickets in comments. So I think it should be configurable (through TracIni) to allow parsing of TracLinks before showing any text-like file in the repository (through Browser.py).

[cboos]

The text/x-trac-links idea is a good one. I also like the idea of TracLinks highlighting in C++ code comment.

There's also some material on the Mailing List on that issue:

• Wiki links to code? (start of the thread)
• my reply

(actually, have a look at for some prior art :) ).

[cboos]

See also #1292

[cboos]

I'll find this one quicker next time I'll be looking for it ;-)