Allow '+' in dynamic variable value, or allow to configure regexp

[bitserf@…]

Hi,

We were having problems with our downloadable reports, as we authenticate all users against a Domain Controller using PAM. Samba translates the '\' in the username DOMAIN\user into DOMAIN+user.

The reports don't like this, as the dynvars_disallowed_value_chars_re regular expression does not include the '+' character.

In addition, the backtrace is not very useful, as the error occurs before self.error/self.rows/self.cols has any value, so the error message is "Report instance has no attribute 'error'" instead of the real message "report failed: xxx" as I expected the code would produce.

The error occurred against 0.8, but looking at the 0.8.1 code, it seems that it would still occur.

Our current (now working) regex:

dynvars_disallowed_value_chars_re = re.compile('[^a-zA-Z0-9-_@.,\+]')

[bitserf@…]

To clarify: The error occurs because the request argument 'USER' contains a name like 'DOMAIN+username'.

[mgood]

This was addressed in #2536