Edgewall Software

Ticket #1198 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 months ago

User filter for Timeline

Reported by: mrovner@… Owned by: rblank
Priority: high Milestone: 0.12
Component: timeline Version: 0.8
Severity: normal Keywords: user patch
Cc: ijones@…, matthew.bassett@…, hshin@…, wfragg@…, pkou@…, s.lipnevich@…, ealtin@…, metajack@…, m.gilbert@…, hyugaricdeau@…, marcandre.lureau@…, rwargo@…, mat@…, a.a.vykhodtsev@…, tapted@…

Description (last modified by cboos) (diff)

The two attached patches (to files Timeline.py and timeline.cs) implement user filtering for the Timeline.

If user name is entered in input field, output only lines belonging to that user.

Attachments

Timeline.py.diff (3.8 KB) - added by mrovner@… 4 years ago.
svn diff for ver 1238
timeline.cs.diff (0.5 KB) - added by mrovner@… 4 years ago.
svn diff for ver 1238
trac-timeline-author-1198.patch (16.1 KB) - added by davidf@… 6 months ago.
Patch to r7176 (0.11 branch) to enable filtering attachments by author name
1198-timeline-author-filter-r7499.patch (2.7 KB) - added by rblank 3 months ago.
Patch against trunk adding author filtering to timeline

Change History

Changed 4 years ago by mrovner@…

svn diff for ver 1238

Changed 4 years ago by mrovner@…

svn diff for ver 1238

  Changed 3 years ago by cboos

  • owner changed from jonas to cboos
  • milestone set to 1.0

#2487 has been marked as duplicate.

Note that the patches provided on this ticket are too old for Trac 0.9.

It's not possible to achieve that with a plugin, either, because the ITimelineEventProvider currently provide only checkbox filters, which are only used to conditionally add all the events provided by that provider.

What would be needed is a new ITimelineEventFilter, which would see all the events and filter out some of them.

  Changed 3 years ago by mbass <matthew.bassett@…>

  • cc mbass added

  Changed 3 years ago by mbass <matthew.bassett@…>

  • cc matthew.bassett@… added; mbass removed

  Changed 3 years ago by mbass <matthew.bassett@…>

  • cc matthew.bassett@… added; matthew.bassett@… removed

  Changed 3 years ago by anonymous

  • cc matthew.bassett@… added; matthew.bassett@… removed

  Changed 3 years ago by anonymous

  • cc matthew.bassett@… added; matthew.bassett@… removed

  Changed 3 years ago by cboos

#843 has been marked as duplicate.

  Changed 3 years ago by anonymous

  • cc matthew.bassett@…, hshin@…, wfragg@…, pkou@… added; matthew.bassett@… removed

  Changed 2 years ago by Russell Hind <rhind@…>

  • cc rhind@… added

We've just started to have to produce logs for what work we have done each work. The timeline filtered by each user seems like an ideal place for use to be able to look back and see what a user has done.

Thanks

Russell

  Changed 2 years ago by anonymous

  • priority changed from normal to high
  • type changed from defect to enhancement
  • severity changed from normal to minor

  Changed 2 years ago by cboos

#4030 was marked as duplicate.

  Changed 2 years ago by anonymous

  • cc s.lipnevich@… added

  Changed 2 years ago by ealtin@…

  • cc ealtin@… added

  Changed 22 months ago by cboos

  • keywords user added
  • description modified (diff)
  • milestone changed from 1.0 to 0.11

#4700 marked as duplicate... hm, looking at the CC: list, seems like this feature request is overdue ;)

  Changed 22 months ago by Jack Moffitt <metajack@…>

  • cc metajack@… added

  Changed 22 months ago by anonymous

  • cc m.gilbert@… added

  Changed 21 months ago by cboos

A new patch has been contributed for 0.10, see #4964.

  Changed 19 months ago by cboos

  • cc hyugaricdeau@… added

Another patch has been contributed for 0.11 in #5242. I'll test it and quite probably integrate it soon.

  Changed 16 months ago by anonymous

  • cc marcandre.lureau@… added

  Changed 13 months ago by ijones

  • cc ijones@… added

  Changed 12 months ago by anonymous

  • cc rwargo@… added

  Changed 9 months ago by anonymous

  • cc mat@… added

  Changed 8 months ago by trac@…

Is there a version of this that works for 11b1? If so where?

  Changed 6 months ago by davidf@…

I've just implemented this for latest trac 0.11 svn - it changes the filters API, I'm not sure if this should go into 0.11, but at least I'll make the patch available here for people...

Changed 6 months ago by davidf@…

Patch to r7176 (0.11 branch) to enable filtering attachments by author name

  Changed 6 months ago by rhind@…

  • cc rhind@… removed

follow-up: ↓ 31   Changed 6 months ago by davidf@…

Note that the attached patch should handle filters in the previous format; still I'm not sure what the procedure for updating the API is.

Also, it seems that this could be implemented all inside the timeline code by simply looking at the generated author property that is part of the events tuple. Anyway, it seems to work :-)

  Changed 4 months ago by eblot

#7460 marked as a duplicate

  Changed 4 months ago by cboos

  • owner cboos deleted
  • severity changed from minor to normal
  • milestone changed from 0.11.2 to 0.12

As it's not a minor improvement, this should rather be targeted for 0.12 (at least). People that really want the feature earlier could use the patch (attachment:trac-timeline-author-1198.patch), which still applies cleanly (with some fuzz).

The approach taken in the patch is interesting. Also, this would need some deeper changes (and maybe even a different approach) to allow for multiple user or even group filtering, which are natural extensions of this feature.

  Changed 4 months ago by a.a.vykhodtsev@…

  • cc a.a.vykhodtsev@… added

  Changed 3 months ago by tapted@…

  • cc tapted@… added

Changed 3 months ago by rblank

Patch against trunk adding author filtering to timeline

in reply to: ↑ 26   Changed 3 months ago by rblank

  • keywords patch added
  • owner set to rblank

Replying to davidf@…:

Also, it seems that this could be implemented all inside the timeline code by simply looking at the generated author property that is part of the events tuple.

You know, this is an excellent idea! The patch above does just that.

Please test the patch and report any problems. If there are no objections, I'll apply it to trunk.

  Changed 3 months ago by osimons

Tested, and works well. +1.

  Changed 3 months ago by rblank

  • status changed from new to closed
  • resolution set to fixed

Patch applied in [7504].

Add/Change #1198 (User filter for Timeline)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from rblank. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.