Edgewall Software

Ticket #5941: milestone-edit.patch

File milestone-edit.patch, 1.2 KB (added by Remy Blank <remy.blank@…>, 4 months ago)

Make editing milestones less dangerous

  • trac/ticket/roadmap.py

    diff --git a/trac/ticket/roadmap.py b/trac/ticket/roadmap.py
    a b  
    644644        if milestone.exists: 
    645645            milestone.update() 
    646646            # eventually retarget opened tickets associated with the milestone 
    647             if 'retarget' in req.args: 
     647            if 'retarget' in req.args and completed: 
    648648                cursor = db.cursor() 
    649649                cursor.execute("UPDATE ticket SET milestone=%s WHERE " 
    650650                               "milestone=%s and status != 'closed'", 
  • trac/ticket/templates/milestone_edit.html

    diff --git a/trac/ticket/templates/milestone_edit.html b/trac/ticket/templates/milestone_edit.html
    a b  
    6666            </label> 
    6767            <py:if test="milestones"> 
    6868              <br/> 
    69               <input type="checkbox" id="retarget" name="retarget" checked="checked" /> 
     69              <input type="checkbox" id="retarget" name="retarget" checked="${not milestone.completed or None}" /> 
    7070              <label>Retarget associated open tickets to milestone: 
    7171                <select id="target" name="target" py:with="t = req.args.get('target')"> 
    7272                  <option value="">None</option>